Skip to content

Conversation

@S-Saranya1
Copy link
Contributor

@S-Saranya1 S-Saranya1 commented Oct 23, 2025

Move ApplyUserAgentStage to later stage in request pipeline

Motivation and Context

Currently facing issue in few stages (like CompressRequestStage and HttpChecksumStage) where business metrics are recorded after User-Agent is finalized, causing metrics to not appear in the header. Moving ApplyUserAgentStage later in the pipeline will eliminate this issue.

Modifications

Moved ApplyUserAgentStage to execute after HttpChecksumStage in the request pipeline in AmazonSyncHttpClient and AmazonAsyncHttpClient.

Testing

  • Checked all the existing tests are passing.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@S-Saranya1 S-Saranya1 requested a review from a team as a code owner October 23, 2025 21:02
@S-Saranya1 S-Saranya1 changed the title Move ApplyUserAgentStage to later position in request pipeline Move ApplyUserAgentStage to later stage in request pipeline Oct 23, 2025
@S-Saranya1 S-Saranya1 added the no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required label Oct 23, 2025
@S-Saranya1 S-Saranya1 added this pull request to the merge queue Oct 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2025
@S-Saranya1 S-Saranya1 added this pull request to the merge queue Oct 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 24, 2025
@S-Saranya1 S-Saranya1 enabled auto-merge October 24, 2025 19:26
@sonarqubecloud
Copy link

@S-Saranya1 S-Saranya1 added this pull request to the merge queue Oct 24, 2025
Merged via the queue into master with commit 3bcbb1c Oct 24, 2025
39 checks passed
@github-actions
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2025
@S-Saranya1 S-Saranya1 deleted the somepal/move-applyUserAgent-later-stage branch October 24, 2025 20:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants